Skip to content

S
shopify_iossdk
Commit a8fd24b9 by Dima Bart
Options

Rename `applyGiftCardWithCode` -> `applyGiftCardCode`.

parent 4efa5fad
Showing with 7 additions and 7 deletions
Mobile Buy SDK/Mobile Buy SDK Tests/BUYIntegrationTest.m
...@@ -296,7 +296,7 @@ ...@@ -296,7 +296,7 @@
XCTestExpectation *expectation = [self expectationWithDescription:NSStringFromSelector(_cmd)]; XCTestExpectation *expectation = [self expectationWithDescription:NSStringFromSelector(_cmd)];
[self.client applyGiftCardWithCode:self.giftCardCode toCheckout:_checkout completion:^(BUYCheckout *checkout, NSError *error) { [self.client applyGiftCardCode:self.giftCardCode toCheckout:_checkout completion:^(BUYCheckout *checkout, NSError *error) {
XCTAssertNil(error); XCTAssertNil(error);
_checkout = checkout; _checkout = checkout;
...@@ -331,7 +331,7 @@ ...@@ -331,7 +331,7 @@
[OHHTTPStubs stubUsingResponseWithKey:@"testApplyingInvalidGiftCardToCheckout_2" useMocks:[self shouldUseMocks]]; [OHHTTPStubs stubUsingResponseWithKey:@"testApplyingInvalidGiftCardToCheckout_2" useMocks:[self shouldUseMocks]];
XCTestExpectation *expectation = [self expectationWithDescription:NSStringFromSelector(_cmd)]; XCTestExpectation *expectation = [self expectationWithDescription:NSStringFromSelector(_cmd)];
[self.client applyGiftCardWithCode:@"000" toCheckout:_checkout completion:^(BUYCheckout *checkout, NSError *error) { [self.client applyGiftCardCode:@"000" toCheckout:_checkout completion:^(BUYCheckout *checkout, NSError *error) {
XCTAssertNotNil(error); XCTAssertNotNil(error);
XCTAssertEqual(422, error.code); XCTAssertEqual(422, error.code);
...@@ -355,7 +355,7 @@ ...@@ -355,7 +355,7 @@
[OHHTTPStubs stubUsingResponseWithKey:@"testApplyingInvalidGiftCardToCheckout_2" useMocks:[self shouldUseMocks]]; [OHHTTPStubs stubUsingResponseWithKey:@"testApplyingInvalidGiftCardToCheckout_2" useMocks:[self shouldUseMocks]];
XCTestExpectation *expectation = [self expectationWithDescription:NSStringFromSelector(_cmd)]; XCTestExpectation *expectation = [self expectationWithDescription:NSStringFromSelector(_cmd)];
[self.client applyGiftCardWithCode:self.giftCardCodeExpired toCheckout:_checkout completion:^(BUYCheckout *checkout, NSError *error) { [self.client applyGiftCardCode:self.giftCardCodeExpired toCheckout:_checkout completion:^(BUYCheckout *checkout, NSError *error) {
XCTAssertNotNil(error); XCTAssertNotNil(error);
XCTAssertEqual(422, error.code); XCTAssertEqual(422, error.code);
...@@ -471,7 +471,7 @@ ...@@ -471,7 +471,7 @@
NSDecimalNumber *originalPaymentDue = [_checkout.paymentDue copy]; NSDecimalNumber *originalPaymentDue = [_checkout.paymentDue copy];
XCTestExpectation *expectation = [self expectationWithDescription:NSStringFromSelector(_cmd)]; XCTestExpectation *expectation = [self expectationWithDescription:NSStringFromSelector(_cmd)];
[self.client applyGiftCardWithCode:self.giftCardCode2 toCheckout:_checkout completion:^(BUYCheckout *checkout, NSError *error) { [self.client applyGiftCardCode:self.giftCardCode2 toCheckout:_checkout completion:^(BUYCheckout *checkout, NSError *error) {
XCTAssertNil(error); XCTAssertNil(error);
_checkout = checkout; _checkout = checkout;
...@@ -517,7 +517,7 @@ ...@@ -517,7 +517,7 @@
NSDecimalNumber *originalPaymentDue = [_checkout.paymentDue copy]; NSDecimalNumber *originalPaymentDue = [_checkout.paymentDue copy];
XCTestExpectation *expectation = [self expectationWithDescription:NSStringFromSelector(_cmd)]; XCTestExpectation *expectation = [self expectationWithDescription:NSStringFromSelector(_cmd)];
[self.client applyGiftCardWithCode:self.giftCardCode3 toCheckout:_checkout completion:^(BUYCheckout *checkout, NSError *error) { [self.client applyGiftCardCode:self.giftCardCode3 toCheckout:_checkout completion:^(BUYCheckout *checkout, NSError *error) {
//NOTE: Is this test failing? Make sure that you have configured giftCardCode above //NOTE: Is this test failing? Make sure that you have configured giftCardCode above
XCTAssertNil(error); XCTAssertNil(error);
_checkout = checkout; _checkout = checkout;
......
Mobile Buy SDK/Mobile Buy SDK/Data/BUYClient+Checkout.h
...@@ -197,7 +197,7 @@ typedef void (^BUYDataGiftCardBlock)(BUYGiftCard * _Nullable giftCard, NSError * ...@@ -197,7 +197,7 @@ typedef void (^BUYDataGiftCardBlock)(BUYGiftCard * _Nullable giftCard, NSError *
* *
* @return The associated BUYRequestOperation * @return The associated BUYRequestOperation
*/ */
- (BUYRequestOperation *)applyGiftCardWithCode:(NSString *)giftCardCode toCheckout:(BUYCheckout *)checkout completion:(BUYDataCheckoutBlock)block; - (BUYRequestOperation *)applyGiftCardCode:(NSString *)giftCardCode toCheckout:(BUYCheckout *)checkout completion:(BUYDataCheckoutBlock)block;
/** /**
* Removes a gift card from the checkout. * Removes a gift card from the checkout.
......
Mobile Buy SDK/Mobile Buy SDK/Data/BUYClient+Checkout.m
...@@ -235,7 +235,7 @@ ...@@ -235,7 +235,7 @@
}]; }];
} }
- (BUYRequestOperation *)applyGiftCardWithCode:(NSString *)giftCardCode toCheckout:(BUYCheckout *)checkout completion:(BUYDataCheckoutBlock)block - (BUYRequestOperation *)applyGiftCardCode:(NSString *)giftCardCode toCheckout:(BUYCheckout *)checkout completion:(BUYDataCheckoutBlock)block
{ {
BUYAssertCheckout(checkout); BUYAssertCheckout(checkout);
BUYAssert(giftCardCode.length > 0, @"Failed to apply gift card code. Invalid gift card code."); BUYAssert(giftCardCode.length > 0, @"Failed to apply gift card code. Invalid gift card code.");
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment